Skip to content
← Skill pack

Coding-agent skill · 07

Ready-for-Review

Is this actually ready for a person to review?

Use when: Preparing a feature branch or an open pull request for review, with the checks passing. It stops short of merging.

Portable source

Plain Markdown · MIT · 2,516 bytes

SHA-256 be044e4e8f09e199f66f16fbc4d2f676ac77361889879574fd01ef788ca5dba3

A green badge is evidence about one commit. It is not proof the product does what the person asked for.

Confirm what you're actually authorized to do

Check the working tree, the target branch, and any existing pull request before touching anything, and make sure the request actually covers pushing a branch and opening or updating a PR — this step grants no access on its own. Stage only the paths you own; never sweep up unrelated changes, lockfile churn, or someone else's work in progress out of habit.

Sync before burning a CI cycle

Fetch the real base branch and follow the repository's own merge or rebase convention, keeping a recovery point before rewriting any shared history. Resolve conflicts only when the correct behavior is genuinely clear — stop and ask rather than picking a side arbitrarily just to push through.

Run the checks that actually matter

Pull the acceptance commands from the project's real CI configuration and scripts instead of assuming a toolchain, then run formatting, type checks, and the tests that cover what actually changed. Read the full diff for stubs, disabled assertions, and quietly weakened checks before calling anything done.

Write a pull request a human can trust

Describe what the change actually solves, what was tested and what was not, and any compatibility or rollback concerns — link to evidence instead of pasting a transcript, and never claim a deployment or test that did not happen.

Chase the real failure, not a lucky rerun

Watch the checks, read the first failing job's actual log, and fix the underlying cause with the project's own tooling. Reproduce a failure on the base branch before calling it pre-existing, and never reach green by deleting a test, loosening a type, or suppressing an error.

Hand off without crossing the finish line

Confirm every required check is green on the exact commit that was pushed, not an earlier one, then hand over the PR link, the commit, and a plain account of what is tested and what is still open. Leave the merge button to the reviewer.